mirror of
https://github.com/rohitg00/skillkit.git
synced 2026-11-19 02:13:58 +00:00
feat/eval-system
21
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
7c8ba72462 |
fix: update docs, TUI help, and website for v1.19.2 gaps (#82)
- docs/index.mdx: version v1.18.0 → v1.19.2, add skills.sh install source, add methodology packs to next steps - docs/rest-api.mdx: health check example version 1.12.0 → 1.19.2 - docs/methodology.mdx: new page documenting 5 packs with 14 skills - docs/meta.json: add methodology to page ordering - Hero.tsx: show skills.sh install in terminal animation - Help.tsx: fix shortcut conflicts — add Session section (l=Timeline, v=Lineage, f=Handoff), remove stale f=Find/v=Validate mappings |
||
|
|
2fe4702bd6 |
chore: migrate domain to skillkit.sh (#70)
* chore: migrate domain from agenstskills.com to skillkit.sh Update all OG/Twitter meta tags, API endpoints, docs links, badge URLs, privacy policy, extension store listing, and README references to use skillkit.sh. Both skillkit.sh and agenstskills.com are treated as equal domains — privacy policy, store listing, and docs reference both. * perf: skip Vercel builds when docs unchanged Add ignoreCommand to both docs/skillkit and docs/fumadocs vercel.json. Vercel will skip rebuilds when the respective docs folder has no changes, saving ~1h+ of build minutes per billing cycle. |
||
|
|
64cafc76a1 |
feat: add TUI screens for session intelligence (timeline, lineage, handoff) (#68)
Wire up 3 new screens from PR #65's session intelligence commands into the TUI with keyboard navigation (l=timeline, v=lineage, f=handoff) and a new Session sidebar section. |
||
|
|
f11de2ac63 |
feat: add 12 missing AI coding agents (32 to 44) (#56)
* feat: add 12 missing AI coding agents (Devin, Aider, Cody, Amazon Q, Augment, Replit, Bolt, Lovable, Tabby, Tabnine, CodeGPT, PlayCode) Expands agent support from 32 to 44 agents across all packages: - Core types, configs, discovery paths, format maps, command generator - Agent adapters (UniversalAdapter for all new agents) - CLI onboarding icons/names, TUI symbols/logos - Updated all docs, tests, and e2e references from 32 to 44 * test: add comprehensive tests for new agents, update docs and e2e - Add it.each tests for all 12 new agent adapters and configs - Add completeness test ensuring every AgentType has adapter + config - Update agents.mdx doc table with all 12 new agents - Update e2e onboarding test with new agent display names * fix: add all 44 agents to translateSkillToAll and fix e2e test - translateSkillToAll had hardcoded 17-agent list, now includes all 44 - e2e/skill-translator test was missing cline-zencoder batch in SUPPORTED_AGENTS * fix: replace UniversalAdapter with GenericAgentAdapter for all non-universal agents UniversalAdapter hardcoded type='universal', skillsDir='skills', and name='Universal (Any Agent)' for all 26 agents that used it. This caused skills to install to wrong directories and agents to be undetectable. GenericAgentAdapter reads type, skillsDir, configFile from AGENT_CONFIG and checks agent-specific directories in isDetected(). Fixes both the 12 new agents and the 14 pre-existing ones (cline through zencoder). 115 adapter tests now verify correct type, skillsDir, configFile, and name for every GenericAgentAdapter instance. |
||
|
|
2bf8c7499c |
docs: add security scanner documentation, TUI screen, and README updates (#53)
- Add dedicated security.mdx docs page with full rule reference (46+ rules), threat categories, SARIF/CI integration guide, and programmatic usage - Add TUI Scan screen (z key) with live scan results, severity colors, finding navigation, and rescan support - Add scan to TUI sidebar nav, help shortcuts, and bottom status bar - Add security scanner section to docs index page with link - Add programmatic scan usage example to CLI README - Remove stale --quiet option from commands.mdx - Add security page to docs sidebar navigation |
||
|
|
8121c2bbac |
feat(core): add PageIndex-inspired patterns for skill discovery (#37)
* feat(core): add PageIndex-inspired patterns for skill discovery Implements patterns from anthropics/knowledge-work-plugins: Tree Module (packages/core/src/tree/): - Hierarchical skill taxonomy with 12 categories - Tree generator from skill tags and metadata - Tree serializer for JSON/Markdown export - Related skills graph with 4 relation types Reasoning Engine (packages/core/src/reasoning/): - LLM-based tree traversal for skill discovery - Explainable recommendations with reasoning chains - Search planning with category relevance scoring - Result caching with 5-minute TTL Connectors (packages/core/src/connectors/): - Tool-agnostic ~~ placeholder system - 13 connector categories (crm, chat, email, etc.) - Auto-suggest mappings from MCP config - Placeholder detection and replacement utilities Execution Flow (packages/core/src/execution/): - Step-by-step execution tracking with metrics - Automatic retry with exponential backoff - Standalone vs Enhanced mode detection - Capability-based feature gating CLI Integration: - New `skillkit tree` command with --generate, --stats flags - Enhanced `skillkit recommend` with --explain, --reasoning flags TUI Integration: - Tree view mode in Marketplace (toggle with 'v') - Arrow key navigation for tree hierarchy * fix: address CodeRabbit and Devin review feedback - Use os.homedir() instead of process.env.HOME || '~' fallback (tree.ts, tree.service.ts, mode.ts) - Add guard for division by zero in tree stats percentage - Validate parseInt result for --depth flag - Fix average stats calculation to use cacheMisses count - Extract category from data in validateCategoryScore - Remove unused skillMap field from TreeGenerator - Make reasoning provider configurable instead of hardcoded - Add try/catch for tree loading errors in Marketplace - Handle missing tree nodes during traversal * fix(execution): clear timeout timer to prevent resource leak Store setTimeout ID and clear it in finally block when step completes successfully before timeout. This prevents orphaned timers from accumulating during long-running applications. |
||
|
|
12ed10d170 |
refactor(tui): migrate to OpenTUI/Solid.js framework (#32)
* refactor(tui): migrate to OpenTUI/Solid.js framework Complete TUI rewrite from Ink/React to OpenTUI/Solid.js: - Replace React with Solid.js for reactive state management - Migrate all 20 screens to OpenTUI component primitives - Add monochromatic design with 14 color themes - Implement cinematic splash screen with ASCII animation - Add vi-key navigation (j/k/h/l) throughout - Create 32 reusable components with consistent styling - Add service layer for @skillkit/core API integration - Remove deprecated react-opentui.d.ts type definitions - Update build config for Solid.js JSX transform Features covered: - Browse, Marketplace, Recommend (discovery) - Installed, Sync, Translate (management) - Workflow, Execute, Plan, History (execution) - Team, Context, Memory, Mesh, Message (collaboration) - Plugins, Methodology, Settings (configuration) - Help screen with 25+ keyboard shortcuts * fix(tui): address CodeRabbit review feedback Critical fixes: - Remove non-existent module exports from index.tsx (context, themes, ui, hooks, services) - Simplify App.tsx to remove missing context provider imports Major fixes: - ProgressBar: Add defensive guards for width/progress (NaN, Infinity, negative) - Browse: Fix filtered index loading wrong repository - Context: Add section navigation (h/l keys) and async error handling - Methodology: Add error handling with try/catch/finally for all async ops - Plan: Fix division by zero when plan has no tasks, add error handling - Team: Add error handling for loadTeamConfig and handleInitialize - Translate: Guard against missing skill.path before read operations * fix(tui): address remaining CodeRabbit feedback - Memory: Add error handling for loadData, handleDelete, handleClearAll, handleInitialize - Team: Fix key conflict by blocking global keys when detail pane is open - animations: Fix springCurve to return 0 at progress=0 and 1 at progress=1 * fix(tui): add Solid.js OpenTUI type definitions Required for TypeScript to recognize OpenTUI JSX elements (box, text, span) with their custom props (fg, bg, flexDirection, etc.) * fix(tui): add stub services and fix type errors for CI - Add minimal stub service implementations for all TUI screens: - context.service.ts - project context loading - executor.service.ts - skill execution - memory.service.ts - memory management - methodology.service.ts - methodology packs - plan.service.ts - plan management - plugin.service.ts - plugin management - recommend.service.ts - skill recommendations - team.service.ts - team collaboration - translator.service.ts - skill translation - workflow.service.ts - workflow orchestration - Fix type errors in screens: - Plan.tsx: Add non-null assertions for optional issues array - Plugins.tsx: Cast getPluginInfo result to Plugin type These stubs provide the expected interfaces for screens while the full integration with @skillkit/core is completed later. * fix(tui): add missing component files for CI Add the component files that screens depend on: - StatusIndicator - loading/success/error status display - DetailPane - side panel for detailed view - EmptyState/ErrorState - empty and error state components - SelectList - selection list component - SplitPane - split view layout - AnimatedText - text animations - Breadcrumb - navigation breadcrumb - Button/Clickable - interactive elements - CodeBlock - code display - FormField - form input wrapper - HoverHighlight - hover effect wrapper - RightSidebar/BottomStatusBar - layout components - TabBar - tab navigation - ErrorBoundary - error handling wrapper These components are required by the screen files and were missing from the previous commit. * fix(tui): resolve context import and duplicate export issues - RightSidebar: inline sidebar state instead of importing from context - services/index.ts: fix duplicate AgentType export by using explicit exports for executor and translator services * fix(tui): use export type for type-only re-exports * refactor(tui): simplify components and remove redundant exports * refactor(tui): remove unused imports and variables Code simplification pass: - Remove unused onCleanup import from Workflow, Recommend, Sync screens - Remove unused contentWidth from Browse, Recommend, Marketplace, Sync - Remove unused cols from Browse, Recommend - Remove unused JSX import from EmptyState component - Remove unused translate import from Sync screen - Remove unused SelectList import and listItems function from Memory screen * fix(tui): wire up interactive handlers and fix type definitions - AnimatedText: fix reactive dependency tracking in createEffect - BottomStatusBar: remove unused width prop - Breadcrumb: wire onNavigate handlers, fix off-by-one in getPathAtIndex - Button: wire onClick with disabled check, apply paddingX, fix ButtonGroup spacing - Clickable: wire click/double-click/right-click handlers, fix InteractiveArea - DetailPane: make close button interactive - ErrorBoundary: use terminal keyboard handler, prevent duplicate onError calls - FormField: fix placeholder show condition for empty string - SelectList: add onSelect/onHover interactive behavior - SplitPane: preserve string sizes like "50%" in width/height helpers - TabBar: wire onSelect callbacks for both horizontal and vertical variants - solid-opentui.d.ts: add missing event handler types to BoxProps/TextProps * fix(tui): address Devin review issues - App: restore process.exit(0) fallback when onExit is undefined - Execute: pass skill path instead of content to executeSkillWithAgent - Memory: add useKeyboard handler for j/k/Enter/d/c/i/Esc shortcuts * fix(tui): address Devin and CodeRabbit review issues Security & Robustness: - App: use execFile instead of exec to prevent command injection in openUrl - App: clamp cols/rows to minimum 1 to prevent negative dimensions - index: await render() and handle failures with exitTUI(1) Execute screen: - Add error state for load failures - Prevent re-entrant execution with executing() guard - Use try/finally to always clear executing state Memory screen: - Add missing 'r' shortcut for retry/refresh Workflow screen: - Use try/finally to always clear executing state even on rejection Sync screen: - Capture selectedIndex and agent values before await to prevent drift * fix(tui): implement list windowing to keep selection visible Execute, Marketplace, Recommend screens now use windowed list rendering that follows the selection, preventing the selected item from being off-screen when navigating through long lists. - Add createMemo for computing visible window based on selectedIndex - Show ▲/▼ indicators when items are above/below the visible window - Navigate through full list instead of clamping to visible window size * fix(tui): add error handling and index clamping Marketplace.tsx: - Set error signal when all repos fail or no skills loaded - Add reactive effect to clamp selectedIndex when filteredSkills changes Recommend.tsx: - Wrap loadData in try/catch to surface errors in UI - Clamp selectedIndex after recommendations update * fix(tui): add error handling to Plugins and Workflow screens Plugins.tsx: - Wrap loadData in try/catch to prevent stuck loading state - Wrap handleToggle in try/catch/finally to always reset toggling flag - Wrap handleShowDetail in try/catch to surface errors gracefully Workflow.tsx: - Wrap loadData in try/catch to prevent stuck loading state - Add catch block to handleExecute to show execution errors in UI |
||
|
|
ae78e2e373 |
feat(tui): add Mesh and Message screens for v2.0 features
- Add Mesh screen for mesh network management - Add Message screen for inter-agent messaging - Update App.tsx with navigation to new screens - Add 'g' and 'j' keyboard shortcuts for mesh/message - Update README with mesh and message CLI commands |
||
|
|
40e685fabe |
docs: update README and TUI with new commands and docs link
- Add docs badge and link to README - Add all new commands: check, find, manifest, fix, audit, publish, status, pause/resume, settings, methodology, plan, plugin, team, hook, command - Reorganize commands into logical sections - Update TUI Help screen with new shortcuts - Add 'd' key to open docs in browser from TUI |
||
|
|
6445d72c80 |
fix: address CodeRabbit PR review issues
- Add noopener to rel="noreferrer" for tabnabbing protection - Fix standalone skill path handling in readSkillContent and validateSkill - Derive TOTAL_AGENTS from adapters instead of hardcoded value - Fix duplicate discovery path for droid/factory agents - Create dedicated FactoryAdapter instead of using UniversalAdapter |
||
|
|
d1fcf0355f |
docs: add comprehensive documentation section to website (#23)
* docs: add comprehensive documentation section to website - Create Documentation.tsx component with DeepWiki-sourced content - Add sections: Overview, Installation, Architecture, Agents, Commands - Add sections: Configuration, API Reference, Skill Format, Tech Stack - Include interactive sidebar navigation - Add Docs link to navbar - Reference DeepWiki as documentation source Source: https://deepwiki.com/rohitg00/skillkit * feat(docs): add Fumadocs documentation site and update website - Add Fumadocs-based documentation site at /docs - Complete MDX documentation for all features - TUI section with keyboard navigation - Installation, quickstart, commands reference - API reference and configuration guides - Update SkillKit website (agentskills.com) - Add 15 new agents (32 total): CodeBuddy, Continue, Crush, Factory, MCPJam, Mux, Neovate, OpenHands, Pi, Qoder, Qwen, Vercel, Zencoder, CommandCode - Update agent count from 17 to 32 across all components - Update command count from 30+ to 40+ - Remove inline Documentation section (now in Fumadocs) - Link Docs to /docs route - Add 15 new agent adapters to @skillkit/agents - All use UniversalAdapter as base - Added to detection order and adapter registry - Configure Vercel rewrites for /docs proxy to Fumadocs * fix: resolve TypeScript build errors in fumadocs - Remove createRelativeLink from docs page (not compatible with current fumadocs) - Remove redundant isLoading prop in SkillGenerator (status already narrowed) - Fix lucide-react icon type casting in Card component - Fix MDXComponents return type in mdx-components * fix: resolve /docs 404 and show docs link on mobile - Handle undefined slug by defaulting to empty array for index page - Remove hidden class from Docs link so it shows on mobile * fix: address CodeRabbit review suggestions - Move Gemini API key to server-side route (security) - Add default type='button' to Button component - Use dynamic agent count instead of hardcoded 32 - Add 'use client' directive to Documentation - Fix stale closure in SkillSubmitForm with useCallback - Add URL validation for external references - Add noopener to external links for security - Fix Clawdbot path in agents.mdx - Update cicd.mdx with correct CLI commands - Capitalize proper nouns (Markdown, provider names) - Add text language to README code block - Update date example in quickstart.mdx * fix: add noopener to external links and improve nav accessibility - Add noopener to rel attributes on external links for tabnabbing protection - Add aria-label to nav element for screen readers - Add type="button" and aria-current to nav buttons * fix: add vercel.json for fumadocs deployment * fix: disable turbo detection in Vercel deployment * fix: clean up ASCII logo for better rendering * fix: improve code block contrast in SkillGenerator * fix: sync ASCII logo and code block contrast fixes to old Vite components * fix: improve mobile responsiveness for tabs and header buttons * fix: address CodeRabbit security and code quality suggestions - Add rate limiting to API route (10 requests/min per IP) - Add proper type validation for topic parameter - Move API key check after input validation - Add 'use client' directive to SkillGenerator - Add YAML escape helper to prevent frontmatter injection - Change vercel.json to use pnpm instead of npm |
||
|
|
b3f561dbc9 |
feat(quality): Quality Evaluation System Enhancements (#21)
* feat(quality): add skill quality evaluation system - Add quality scoring module with structure, clarity, and specificity metrics - Evaluate skills for metadata, triggers, boundaries, code examples - Detect vague terms and penalize overly long skills - Update validate command to include quality reports - Add --verbose, --quality, --issues, --json flags - Quality scores: A (90+), B (80+), C (70+), D (60+), F (<60) * fix: address CodeRabbit and Devin review suggestions - Fix JSON output to return exit code 1 on validation failures - Add --min-score NaN validation with warning message - Add directory guard for --all flag with .mdc file support - Fix CRLF handling in frontmatter extraction - Fix code blocks double-counting in specificity evaluation - Fix warning message inconsistency for code examples - Add try/catch error handling in evaluateSkillFile - Fix isHighQuality threshold to match UI display (80) * feat(quality): extend quality evaluation system with badges, deeper analysis, and fix command - Phase 2: Add quality badges to CLI commands (list, recommend, install) - formatQualityBadge() helper for color-coded grade badges - --quality flag for list command - Low-quality skill warnings during install - Phase 3: Add TUI quality badges - Extended SkillItem with quality, grade, warnings fields - Quality evaluation in loadSkills() - Grade badges in Installed and Recommend screens - Phase 4: Deeper quality analysis - Deprecated pattern detection (CommonJS, class components, var) - Security pattern detection (hardcoded credentials, eval, innerHTML) - Conflicting instruction detection - Completeness assessment (TODOs, empty sections, example coverage) - New weight distribution: Structure 35%, Clarity 25%, Specificity 25%, Advanced 15% - Phase 1: Pre-compute marketplace quality scores - Updated schema.json with quality field (0-100) - Created scripts/compute-quality.ts for batch computation - Phase 5: Benchmark against category leaders - New benchmark.ts module with category detection - Percentile calculation and comparison notes - --benchmark flag for validate command - Phase 6: Fix command for automated quality fixes - skillkit fix command with --dry-run and --interactive modes - Auto-generates frontmatter, "When to Use", "Boundaries" sections - --fix flag alias on validate command * fix: address CodeRabbit and Devin review suggestions - Fix .mdc file name extraction in fix.ts (handles both .md and .mdc) - Add missing advanced field to test fixtures in quality.test.ts - Fix duplicate header detection in assessCompleteness using regex.exec - Fix ESM compatibility in compute-quality.ts using import.meta.url - Add trailing newline to skills.json output * fix: address remaining CodeRabbit review suggestions - Escape regex metacharacters in vague term patterns (fix.ts) - Improve diff algorithm using set-based comparison (fix.ts) - Fix validateSkill receiving file path instead of directory (validate.ts) - Check final section in completeness assessment (index.ts) - Add error handling and empty skills guard (compute-quality.ts) * fix: address additional review feedback - validate.ts: Add error when --fix is passed without targets - index.ts: Skip headers inside fenced code blocks during completeness check - compute-quality.ts: Use nullish coalescing (??) to preserve zero quality scores |
||
|
|
235130c6ae |
fix(tui): fix rendering overlap and terminal crash on quit (#18)
- Remove deprecated @types/minimatch dependency (minimatch 10.x has bundled types) - Fix TUI text rendering overlap by using single text elements instead of multiple text elements in box rows (Browse, Installed, Marketplace, SkillList screens) - Fix terminal crash on 'q' press by properly unmounting React tree and restoring terminal state with escape sequences - Add signal handlers (SIGINT, SIGTERM) for clean exit - Bump version to 1.7.6 |
||
|
|
4a6003ec46 |
feat: single source of truth for skills marketplace (#15)
* feat: single source of truth for skills marketplace - Consolidate all skills data to marketplace/skills.json (15,062 skills) - Add marketplace/sources.json for curated repository sources (31 repos) - Add skillkit publish command for user skill submissions - Add auto-publish prompt to skillkit init - Add AI skill caching with localStorage (7-day TTL) - Add Submit to Marketplace button for AI-generated skills - Remove duplicate skills.json files (docs, core) - Remove legacy src/tui/ folder (replaced by packages/tui) - Update all imports to use single source files * fix: address CodeRabbit review feedback - Remove duplicate checklist items in SkillSubmitForm.tsx - Add missing sources-schema.json file - Add slugify method for URL-safe skill IDs - Fix Windows browser open command (empty title param) - Fix frontmatter parsing for CRLF and multiline tags * fix: address additional review feedback - Add TTY check to skip prompts in CI/non-interactive environments - Guard against empty slug IDs with validation - Print full URL in fallback (not truncated) - Fix repo name parsing for names containing dots - Add cache pruning and max entries limit (50) for localStorage * fix: filter empty strings from YAML tags array parsing |
||
|
|
6d36a4a3f7 |
Revert "feat: single source of truth for skills marketplace"
This reverts commit
|
||
|
|
0c5eb93891 |
feat: single source of truth for skills marketplace
- Consolidate all skills data to marketplace/skills.json (15,062 skills) - Add marketplace/sources.json for curated repository sources (31 repos) - Add skillkit publish command for user skill submissions - Add auto-publish prompt to skillkit init - Add AI skill caching with localStorage (7-day TTL) - Add Submit to Marketplace button for AI-generated skills - Remove duplicate skills.json files (docs, core) - Remove legacy src/tui/ folder (replaced by packages/tui) - Update all imports to use single source files |
||
|
|
0210556634 |
feat(tui): migrate to OpenTUI with monochromatic design (#11)
* feat(tui): migrate to OpenTUI with monochromatic design ## Summary - Migrate TUI from Ink to OpenTUI framework (requires Bun >=1.2.0) - Implement monochromatic B&W design with colored accents - Add Help screen accessible via `/` key - Fix terminal cleanup on exit (no more escape code garbage) - Clean up code: remove unnecessary comments, simplify components - Add 9 unit tests for TUI state, theme, and utilities ## Breaking Changes - TUI now requires Bun runtime (>=1.2.0) for OpenTUI - Help moved from `?` (requires Shift) to `/` key ## Changes - **index.tsx**: Clean exit handler with ANSI terminal restore - **App.tsx**: Simplified screen routing with switch statement - **Help.tsx**: New help screen with keyboard shortcuts reference - **Home.tsx**: Extract FEATURES constant, simplified agent width logic - **Sidebar.tsx**: Removed unused onNavigate prop usage - **state/types.ts**: Consolidated type definitions, added help screen - **README.md**: Updated with Bun requirement and new architecture ## Test Coverage - 757 tests passing (664 core + 80 agents + 9 tui + 1 cli + 3 app) ## Code Quality - Removed all JSDoc comments describing obvious code - Extracted reusable ShortcutSection component - Replaced nested ternaries with clearer if/else - Moved static data outside components to prevent recreation * fix: address CodeRabbit review issues - AgentGrid: prevent infinite loop when columns <= 0 - Splash: clamp progress width to prevent negative repeat - StatsCard: reset animation state when items change - Help: clamp contentWidth to minimum 1 - Browse: add useKeyboard handler for navigation and search - Installed: add useKeyboard handler for toggle functionality - Marketplace: add useKeyboard handler and clamp contentWidth - Recommend: fix spinner interval, add keyboard handler - Settings: add keyboard handler, fix SETTINGS -> settings state - Sync: add keyboard handler and sync flow implementation - Workflow: add keyboard handler and clamp contentWidth - skills.ts: add path validation to prevent directory traversal * fix: address additional CodeRabbit review issues Splash.tsx: - Change generateParticles from useMemo to useCallback for fresh random rows Browse.tsx: - Clamp maxLen to avoid negative slicing - Add Enter/Return handler to open selected repo Installed.tsx: - Wire up 'd' key to toggle handler - Update shortcuts label from "delete" to "disable" Marketplace.tsx: - Add handleInstall callback for Enter key - Add 'b' key handler to navigate to browse Recommend.tsx: - Add handleInstall callback for Enter key Settings.tsx: - Update shortcuts label from "enter edit" to "enter toggle" Sync.tsx: - Add useRef for timeout cleanup on unmount - Clamp selectedIndex when agents list shrinks Workflow.tsx: - Remove unimplemented shortcuts from display string * fix: address performance and stale closure issues Splash.tsx: - Cache getVersion() with useMemo to avoid repeated sync file I/O Installed.tsx: - Wrap keyboard handler in useCallback to prevent stale closures Settings.tsx: - Wrap keyboard handler in useCallback with proper dependencies Workflow.tsx: - Remove "Press 'n' to create one" text since 'n' key isn't implemented |
||
|
|
1344d65b3d |
feat: implement phases 12-18 - complete agentic development platform (#6)
* feat: implement phases 12-18 - complete agentic development platform This comprehensive update implements 7 major phases (12-18) transforming SkillKit into a universal agentic development platform with methodology packs, hooks, orchestration, planning, and AI capabilities. Phase 12: Methodology Framework - MethodologyManager for pack-based methodology distribution - 5 methodology packs (testing, debugging, planning, collaboration, meta) - 13 curated methodology skills - Pack loader with validation and installation - 56 comprehensive tests Phase 13: Hooks & Automatic Triggering System - HookManager with event-driven skill activation - 10+ event types (session:start, file:open, task:start, etc.) - Pattern-based triggers with glob support - Agent-specific hook generation - 29 comprehensive tests Phase 14: Subagent Orchestration - TeamOrchestrator for multi-agent coordination - TaskManager with cross-agent assignment - Plan approval workflow (submit → approve/reject) - TeamMessageBus for agent communication - Two-stage review system (spec compliance + code quality) - 36 comprehensive tests Phase 15: Structured Plan System - PlanParser for markdown → structured plan conversion - PlanValidator for completeness checking - PlanExecutor with dry-run support - Bite-sized task format (2-5 min atomic tasks) - 36 comprehensive tests Phase 16: Slash Commands & Agent Integration - CommandRegistry for slash command management - Agent-specific command generation (Claude, Cursor, OpenCode) - Command aliases and arguments support - 42 comprehensive tests Phase 17: Enhanced Agent Features - Permission system (allow/deny/ask patterns) - Glob pattern matching for file-scoped skills - Bootstrap files (AGENTS.md, SOUL.md, TOOLS.md) - Multi-mode support (Code/Architect/Debug/Ask) - Agent feature tests Phase 18: Advanced Features (AI & Audit) - AIManager with natural language skill search - Automatic skill generation from examples/code - MockAIProvider for testing without API keys - AuditLogger with complete operation trail - Query, export (JSON/CSV/text), and statistics - 37 comprehensive tests (15 AI + 22 audit) CLI Commands Added: - skillkit methodology list|install|sync - skillkit hook add|remove|list|generate - skillkit plan parse|validate|execute|create - skillkit commands generate|list - skillkit ai search|generate|similar - skillkit audit log|export|stats|clear TUI Enhancements: - Methodology screen (o key) for pack browsing - Plan screen (n key) for plan viewing/execution - Updated navigation and sidebar Test Coverage: - Total: 619 tests passing (582 core + 49 agents + 1 cli + 3 app) - New: 245+ tests for phases 12-18 - Coverage maintained at 80%+ Breaking Changes: None Dependencies: No new external dependencies added * fix: apply CodeRabbit security and quality improvements Security Fixes: - Replace custom glob-to-regex with minimatch to prevent ReDoS vulnerabilities - Fix regex pattern generation in globs.ts using battle-tested library - Eliminate unsafe regex patterns in modes.ts and permissions.ts Code Quality Improvements: - Use shared GlobMatcher utility to eliminate code duplication in modes.ts - Preserve command metadata on updates to prevent data loss - Fix single-file vs directory output path handling in command.ts - Pass --strict flag through to plan validator Race Condition & Concurrency Fixes: - Add Promise-based mutex to prevent race condition in audit logger flush() - Handle both sync and async event listeners to prevent unhandled rejections - Maintain synchronous event emission while safely handling async listeners Data Integrity Fixes: - Fix dependency checking to detect missing dependencies - Rehydrate Date fields when importing tasks from JSON - Fix executePlan to properly detect incomplete tasks State Management: - Add validation for missing step executor (fail fast) - Handle cancellation and reset executor state in finally block - Add 'cancelled' status and event to PlanStatus/PlanEvent types Dependencies: - Add minimatch@^10.0.1 to @skillkit/agents package All 639 tests passing. * docs: update READMEs with Phase 10-18 features - Root README: add minimal "What's New in v1.5.0" section with 5 bullet points - packages/core: add usage examples for Team, Plugin, Methodology, Orchestration, Plan, Hooks - packages/cli: add command sections for team, plugin, methodology, plan, hook, command - packages/tui: add screen descriptions for Marketplace, Workflow, Execute, Team, Plugins, Methodology, Plan, Memory - apps/skillkit: expand with practical usage examples for all new features All updates are clean, user-focused, and avoid AI marketing fluff. * fix: resolve multiple code quality and robustness issues - Fix minimatch dependency: downgrade to ^9.0.0 for Node 18 compatibility - Fix command.ts export: handle directory paths and ensure parent directories exist - Fix command.ts merge: preserve curated examples when merging commands - Fix plan.ts: filter empty entries from comma-separated inputs - Fix audit logger pagination: respect explicit 0 for limit and offset - Fix audit logger: gracefully handle malformed JSON lines without data loss - Fix team orchestrator: prevent task assignment to non-idle agents - Fix plan executor: unblock waitIfPaused() when cancel() is called All 639 tests passing. * fix: additional robustness improvements for plan and executor - Fix plan.ts createPlan: filter empty strings from techStack after split/trim - Fix executor.ts: re-check abort signal after waitIfPaused() in both execute() and executeTask() to prevent running additional tasks/steps after cancellation during pause All 639 tests passing. |
||
|
|
7805a5fd4b |
feat: add team collaboration and plugin system (#4)
* feat: add team collaboration and plugin system
Team Collaboration (Phase 10):
- TeamManager for skill sharing with remote registries
- Skill bundles (create, export, import)
- Team CLI commands: init, share, import, list, sync, remove, bundle-*
- Team TUI screen with navigation key 'a'
Plugin System (Phase 11):
- PluginManager with lifecycle hooks
- Plugin loader (files, npm packages, directories)
- TranslatorPlugin for custom agent formats
- ProviderPlugin for custom skill sources
- CommandPlugin for custom CLI commands
- Plugin CLI commands: list, install, uninstall, enable, disable, info
- Plugins TUI screen with navigation key 'p'
Additional:
- CI/CD command for template generation
- Settings command improvements
- Updated CLAUDE.md with all 11 phases complete
- 359 tests passing
* fix: address PR review comments from Devin
- Fix skill-executor.ts: handle undefined agentToUse when strategy is 'cli'
Previously, if strategy was 'cli' but no CLI agent was available, the
code would fall through and call executeWithAgent with undefined agent,
causing a runtime error.
- Fix cicd.ts: prevent GitLab CI config overwrite without --force
Previously, if .gitlab-ci.yml existed but didn't contain 'skillkit',
it would be overwritten without checking --force. Now it properly
returns early with a helpful message, consistent with CircleCI behavior.
* fix: address PR review comments from CodeRabbit and Devin
Plugin command fixes:
- Fix double-nested .skillkit path when using --global flag
Settings command fixes:
- Add defaultTimeout to help text for available keys
- Wrap const timeout in block scope for switch case
- Fix --set flag validation to require equals sign
Core package fixes:
- Remove .ts from supported plugin extensions (runtime imports fail)
- Store skill name instead of full path in bundle manifest
- Use ESM import for execSync instead of require()
- Replace custom YAML parser with yaml library for proper nested structure handling
TUI screen fixes:
- Guard against empty plugins array in navigation
- Fix empty object pattern in Settings.tsx
- Surface config load failures in Settings screen
- Add manager.load() before sync/import in Team screen
- Guard against empty skills array in Team navigation
- Clamp selection index after skills update
CI/CD command fixes:
- Properly handle skipped workflows (not reported as success)
- Show different final message when nothing was created
- Wrap readFileSync in try/catch for GitLab CI
* fix: address PR review feedback (round 2)
- Security: Add path traversal protection in bundle import
- Fix Plugins.tsx to load plugins from directory before listing
- Fix plugin.ts to persist plugin files to disk on install/uninstall
- Fix Settings.tsx auto-detect vs universal display inconsistency
- Add null check for registry in team/manager.ts sync()
- Thread TeamConfig.auth through provider clone calls
- Fix GitLab CI rules vs only conflict (use rules instead of only)
- Make loadConfig() accept global parameter for --global flag
- Fix relative path detection in plugins/loader.ts (../plugins)
* fix: address PR review feedback (round 3)
- plugin.ts: Add '../' and '~' to isLocalPath detection, use
loader-recognized names (index.js, plugin.json) for single-file copy
- plugin.ts: Remove unused 'basename' import
- settings.ts: Change defaultTimeout validation from < 0 to <= 0
- settings.ts: Use knownKeys whitelist for unknown key detection
- loader.ts: Wrap statSync in try/catch for scanDirectory
- loader.ts: Validate required fields (name, version) before pushing
- loader.ts: Update regex to allow scoped npm names (@scope/name)
- bundle.ts: Resolve targetDir to absolute path for path containment
- Plugins.tsx: Only ignore ENOENT errors, rethrow others
- Plugins.tsx: Load plugins in togglePlugin before enable/disable
* fix: address PR review issues - round 4
CRITICAL fixes:
- loader.ts: Wrap statSync in try/catch in loadPluginsFromDirectory to handle
permission denied and broken symlinks
- bundle.ts: Block path traversal attacks via skill names in importBundle by
validating skill names don't contain / \ or start with .
MAJOR fixes:
- bundle.ts: Use dirname() instead of join('..') for output directory calculation
MINOR fixes:
- plugin.ts: Expand tilde paths (~) before existsSync for proper file operations
- settings.ts: Show defaultTimeout and marketplaceSources in default output
- bundle.ts: Prevent duplicate skill names in bundle with early error
- bundle.ts: Handle single-file skills properly in detectAgents
* fix: address PR review issues - round 5
CRITICAL fixes:
- plugin.ts: Add path traversal protection in uninstallPlugin with name validation
and resolved path checks
- bundle.ts: Fix parseSkillContent to not drop first file when content starts
with "--- file ---" header
MAJOR fixes:
- plugin.ts: Add isValidPluginName() helper and validate plugin.metadata.name
before using in file paths
- plugin.ts: Preserve .mjs extension for single-file ESM plugins
- bundle.ts: Use cross-platform path containment checks with relative() and sep
instead of hardcoded '/'
- loader.ts: Add support for .mjs files (index.mjs, plugin.mjs)
MINOR fixes:
- plugin.ts: Expand tilde (~) path BEFORE calling loadPlugin
- settings.ts: Use null instead of undefined in JSON output for --get so key
is preserved
* fix: allow scoped npm names in isValidPluginName
Update isValidPluginName to allow scoped npm package names like @scope/name
while still preventing path traversal attacks. Uses the same regex pattern
as loader.ts validatePlugin for consistency.
Valid names: my-plugin, @scope/plugin-name
Invalid names: ../evil, .hidden, name\\path, @../evil/name
* fix: handle more relative path patterns in loadPlugin
- Use isAbsolute() for cross-platform absolute path detection
- Add check for paths containing '/' (excluding @scope packages)
- Simplify pattern to source.startsWith('.') for all dot-prefixed paths
- Now correctly handles: plugins/x.js, ../foo, ./bar, .hidden
|
||
|
|
d3ffb79512 |
feat: add session memory system for cross-agent learning (#3)
* feat: add session memory system for cross-agent learning
Implements a lightweight, local-first memory system that works across
all 17 AI coding agents. Key features:
- YAML-based storage (no databases or external services)
- Three memory layers: Session, Project, and Global
- AI-powered compression of observations into learnings
- Cross-agent memory injection with relevance matching
- Progressive disclosure for token efficiency
Core modules:
- ObservationStore: Capture raw session observations
- LearningStore: Persist compressed learnings
- MemoryCompressor: AI/rule-based compression engine
- MemoryInjector: Context-aware memory retrieval
- MemoryObserver: Automatic observation capture
CLI commands (skillkit memory):
- status, search, list, show, compress, export
- import, clear, add, rate, config
TUI integration:
- New Memory screen with tabs (Learnings/Observations/Search)
- useMemory hook for state management
- Updated navigation and keybindings
Code quality improvements:
- Replaced nested ternaries with explicit functions
- Added named constants for magic numbers
- Simplified navigation with lookup map
* feat: add marketplace, testing, CI/CD, workflows, and fix dry-run bug
New Features:
- Skill Marketplace: Aggregates skills from GitHub repos with caching
- Skill Testing Framework: 18+ assertion types for skill validation
- CI/CD Integration: Templates for GitHub Actions, GitLab CI, CircleCI
- Workflow Orchestration: Wave-based parallel skill execution
- Session Management: Pause/resume support with state persistence
- Agent Execution: CLI spawning for claude/codex/gemini/opencode/goose
New CLI Commands:
- skillkit marketplace - Browse and install from marketplace
- skillkit test - Run skill tests with assertions
- skillkit run - Execute skills with orchestration
- skillkit status - Show session state
- skillkit pause/resume - Session management
- skillkit workflow - Workflow management
New TUI Screens:
- Marketplace browser with search
- History viewer with session details
- Workflow management screen
Bug Fix:
- Fixed dry-run mode in memory compress command (Devin review)
The --dry-run flag now properly prevents storing learnings
* fix: add missing yaml dependency to @skillkit/cli
* chore: update pnpm-lock.yaml
* fix: address 7 bugs identified by Devin code review
- Fix MemoryIndexStore ignoring isGlobal flag (memory-index.ts)
- Fix ESM runtime crash using require('yaml') in test runner (runner.ts)
- Fix ESM runtime crash using require('node:fs') in MarketplaceAggregator (aggregator.ts)
- Fix ESM runtime crash using require('node:fs') in SessionManager (manager.ts)
- Fix memory rate command parsing rating from --content instead of positional arg (memory.ts)
- Fix SkillExecutionEngine emitting failed status for paused executions (engine.ts)
- Fix run command misclassifying directories as skill markdown files (run.ts)
* fix: address CodeRabbit/Devin review issues (batch 2)
- Fix resume skipping checkpoint handling in engine.ts
- Add paused status guard before completeExecution call
- Fix NaN% progress when totalSteps=0 in Execute.tsx
- Fix effectiveness ?? instead of || to preserve 0% values in compressor.ts
- Clear cache on source change in aggregator.ts addSource/removeSource
* fix: address critical and major CodeRabbit/Devin issues (batch 3)
Security fixes:
- Remove shell: true from spawn to prevent shell injection (agents.ts)
- Add safe regex test with ReDoS protection (engine.ts)
- Add security warning for verification commands (engine.ts)
Bug fixes:
- Fix global memory index path to use ~/.skillkit/ (compressor.ts, memory-index.ts)
- Add task_complete events and verification to resumeExecution (engine.ts)
- Handle absolute URLs in skill entries (aggregator.ts)
- Implement actual port availability check (runner.ts)
- Remove invalid JUnit report format (templates.ts)
- Add crash guard to workflow list command (workflow/list.ts)
* fix: address remaining CodeRabbit/Devin issues (batch 4)
- ReDoS protection: Add pattern validator to reject dangerous regex patterns
(nested quantifiers, overlapping alternations, excessive quantifiers)
- Add missing 'cancelled' status message in execution engine
- Make completedAt/durationMs optional in TaskExecutionResult
- Fix tag filter to skip untagged tests when tags are specified
- Improve error-solution matching: require keyword similarity + solution indicator
- Validate --limit and sanitize --tags in memory/marketplace CLI commands
- Guard against missing arrays when importing YAML learnings
- Escape YAML frontmatter values to prevent invalid output
- Preserve original learning source when merging learnings
- Fix keyword double-counting in memory index search
- Normalize keywords by stripping punctuation for better matching
|
||
|
|
160d2b1534 |
feat: add TUI enhancements and monorepo structure (#2)
* feat: add TUI enhancements and monorepo structure - Add Translate screen for cross-agent skill translation - Add Context screen for project context management - Add Recommend screen with smart skill recommendations - Fix TUI screen duplication by using fixed height container - Clean up unnecessary comments following code-simplifier principles - Refactor to monorepo structure with @skillkit/core, @skillkit/cli, @skillkit/tui, and @skillkit/agents packages - Add comprehensive tests for translator, context, and recommend features - Update license to Apache-2.0 - Add CONTRIBUTING.md with contribution guidelines * ci: switch from npm to pnpm for monorepo support * ci: use pnpm version from package.json * fix: remove unused import in TUI helpers |