Commit Graph
5 Commits
Author SHA1 Message Date
Rohit Ghumare b3f561dbc9 feat(quality): Quality Evaluation System Enhancements (#21)
* feat(quality): add skill quality evaluation system

- Add quality scoring module with structure, clarity, and specificity metrics
- Evaluate skills for metadata, triggers, boundaries, code examples
- Detect vague terms and penalize overly long skills
- Update validate command to include quality reports
- Add --verbose, --quality, --issues, --json flags
- Quality scores: A (90+), B (80+), C (70+), D (60+), F (<60)

* fix: address CodeRabbit and Devin review suggestions

- Fix JSON output to return exit code 1 on validation failures
- Add --min-score NaN validation with warning message
- Add directory guard for --all flag with .mdc file support
- Fix CRLF handling in frontmatter extraction
- Fix code blocks double-counting in specificity evaluation
- Fix warning message inconsistency for code examples
- Add try/catch error handling in evaluateSkillFile
- Fix isHighQuality threshold to match UI display (80)

* feat(quality): extend quality evaluation system with badges, deeper analysis, and fix command

- Phase 2: Add quality badges to CLI commands (list, recommend, install)
  - formatQualityBadge() helper for color-coded grade badges
  - --quality flag for list command
  - Low-quality skill warnings during install

- Phase 3: Add TUI quality badges
  - Extended SkillItem with quality, grade, warnings fields
  - Quality evaluation in loadSkills()
  - Grade badges in Installed and Recommend screens

- Phase 4: Deeper quality analysis
  - Deprecated pattern detection (CommonJS, class components, var)
  - Security pattern detection (hardcoded credentials, eval, innerHTML)
  - Conflicting instruction detection
  - Completeness assessment (TODOs, empty sections, example coverage)
  - New weight distribution: Structure 35%, Clarity 25%, Specificity 25%, Advanced 15%

- Phase 1: Pre-compute marketplace quality scores
  - Updated schema.json with quality field (0-100)
  - Created scripts/compute-quality.ts for batch computation

- Phase 5: Benchmark against category leaders
  - New benchmark.ts module with category detection
  - Percentile calculation and comparison notes
  - --benchmark flag for validate command

- Phase 6: Fix command for automated quality fixes
  - skillkit fix command with --dry-run and --interactive modes
  - Auto-generates frontmatter, "When to Use", "Boundaries" sections
  - --fix flag alias on validate command

* fix: address CodeRabbit and Devin review suggestions

- Fix .mdc file name extraction in fix.ts (handles both .md and .mdc)
- Add missing advanced field to test fixtures in quality.test.ts
- Fix duplicate header detection in assessCompleteness using regex.exec
- Fix ESM compatibility in compute-quality.ts using import.meta.url
- Add trailing newline to skills.json output

* fix: address remaining CodeRabbit review suggestions

- Escape regex metacharacters in vague term patterns (fix.ts)
- Improve diff algorithm using set-based comparison (fix.ts)
- Fix validateSkill receiving file path instead of directory (validate.ts)
- Check final section in completeness assessment (index.ts)
- Add error handling and empty skills guard (compute-quality.ts)

* fix: address additional review feedback

- validate.ts: Add error when --fix is passed without targets
- index.ts: Skip headers inside fenced code blocks during completeness check
- compute-quality.ts: Use nullish coalescing (??) to preserve zero quality scores
2026-01-28 14:18:42 +00:00
Rohit Ghumare 4a6003ec46 feat: single source of truth for skills marketplace (#15)
* feat: single source of truth for skills marketplace

- Consolidate all skills data to marketplace/skills.json (15,062 skills)
- Add marketplace/sources.json for curated repository sources (31 repos)
- Add skillkit publish command for user skill submissions
- Add auto-publish prompt to skillkit init
- Add AI skill caching with localStorage (7-day TTL)
- Add Submit to Marketplace button for AI-generated skills
- Remove duplicate skills.json files (docs, core)
- Remove legacy src/tui/ folder (replaced by packages/tui)
- Update all imports to use single source files

* fix: address CodeRabbit review feedback

- Remove duplicate checklist items in SkillSubmitForm.tsx
- Add missing sources-schema.json file
- Add slugify method for URL-safe skill IDs
- Fix Windows browser open command (empty title param)
- Fix frontmatter parsing for CRLF and multiline tags

* fix: address additional review feedback

- Add TTY check to skip prompts in CI/non-interactive environments
- Guard against empty slug IDs with validation
- Print full URL in fallback (not truncated)
- Fix repo name parsing for names containing dots
- Add cache pruning and max entries limit (50) for localStorage

* fix: filter empty strings from YAML tags array parsing
2026-01-27 00:02:40 +00:00
Rohit Ghumare 6d36a4a3f7 Revert "feat: single source of truth for skills marketplace"
This reverts commit 0c5eb93891.
2026-01-26 23:15:14 +00:00
Rohit Ghumare 0c5eb93891 feat: single source of truth for skills marketplace
- Consolidate all skills data to marketplace/skills.json (15,062 skills)
- Add marketplace/sources.json for curated repository sources (31 repos)
- Add skillkit publish command for user skill submissions
- Add auto-publish prompt to skillkit init
- Add AI skill caching with localStorage (7-day TTL)
- Add Submit to Marketplace button for AI-generated skills
- Remove duplicate skills.json files (docs, core)
- Remove legacy src/tui/ folder (replaced by packages/tui)
- Update all imports to use single source files
2026-01-26 23:12:23 +00:00
Rohit Ghumare c8172097be feat(marketplace): add community skill submission system (#14)
* feat(marketplace): add community skill submission system

- Add marketplace/skills.json with curated skills collection
- Add marketplace/schema.json for skill validation
- Add marketplace/CONTRIBUTING.md with submission guidelines
- Add skill submission issue template for community contributions
- Add workflow to auto-process approved skill submissions
- Add bundled skills data in core package for offline access

Community members can now submit skills via GitHub Issues, which are
automatically added to the marketplace when approved by maintainers.

* fix: address CodeRabbit review suggestions for marketplace PR

Workflow improvements:
- Add concurrency block to prevent parallel push conflicts
- Fix authorGithub extraction to preserve hyphens in usernames
- Filter empty tags and validate at least one tag exists

Schema improvements:
- Allow dots in repository names (e.g., user/repo.js)
- Copy schema.json to core package data folder for validation

Documentation:
- Add 'text' language tag to code block in CONTRIBUTING.md

Data sync:
- Add skills.json and schema.json to docs/skillkit/data/
2026-01-26 19:20:20 +00:00