From da14f329fd421f463a4188695298f11be836615c Mon Sep 17 00:00:00 2001 From: Rohit Ghumare <48523873+rohitg00@users.noreply.github.com> Date: Sat, 11 Apr 2026 11:45:03 +0100 Subject: [PATCH] feat: quarantine cleanup on failure, federated search by default - Hoist cloneResult above try block so catch can clean up temp dir on any failure path, not just the happy path - Always include GitHub API in find search results (was behind --federated flag, now default) --- packages/cli/src/commands/find.ts | 9 ++++----- packages/cli/src/commands/install.ts | 8 ++++++-- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/packages/cli/src/commands/find.ts b/packages/cli/src/commands/find.ts index 52c1ba46..7bcd6011 100644 --- a/packages/cli/src/commands/find.ts +++ b/packages/cli/src/commands/find.ts @@ -60,8 +60,9 @@ export class FindCommand extends Command { description: "Minimal output (just list skills)", }); - federated = Option.Boolean("--federated,-f", false, { - description: "Search external registries (GitHub SKILL.md files)", + federated = Option.Boolean("--federated,-f", true, { + description: "Search external registries (enabled by default)", + hidden: true, }); async execute(): Promise { @@ -162,9 +163,7 @@ export class FindCommand extends Command { s.start("Searching skills.sh + external registries..."); const fedSearch = new FederatedSearch(); fedSearch.addRegistry(new SkillsShRegistry()); - if (this.federated) { - fedSearch.addRegistry(new GitHubSkillRegistry()); - } + fedSearch.addRegistry(new GitHubSkillRegistry()); try { const fedResult = await fedSearch.search(searchTerm, { limit: parseInt(this.limit, 10) || 10, diff --git a/packages/cli/src/commands/install.ts b/packages/cli/src/commands/install.ts index 595c6fdc..f83c86fd 100644 --- a/packages/cli/src/commands/install.ts +++ b/packages/cli/src/commands/install.ts @@ -132,14 +132,17 @@ export class InstallCommand extends Command { const isInteractive = process.stdin.isTTY && !this.skills && !this.all && !this.yes; const s = spinner(); + let cloneResult: Awaited>["cloneResult"] = null; try { if (process.stdin.isTTY && !this.quiet) { welcome(); } - const { providerAdapter, cloneResult } = await this.resolveSource(s); - if (!providerAdapter || !cloneResult) return 1; + const resolved = await this.resolveSource(s); + if (!resolved.providerAdapter || !resolved.cloneResult) return 1; + const providerAdapter = resolved.providerAdapter; + cloneResult = resolved.cloneResult; const discoveredSkills = cloneResult.discoveredSkills || []; @@ -175,6 +178,7 @@ export class InstallCommand extends Command { return 0; } catch (err) { + if (cloneResult) this.cleanupTemp(cloneResult); s.stop(colors.error("Installation failed")); console.log(colors.muted(err instanceof Error ? err.message : String(err))); return 1;