From 44da0f8592f178079a8a74bf01e628548bf41c21 Mon Sep 17 00:00:00 2001 From: Rohit Ghumare <48523873+rohitg00@users.noreply.github.com> Date: Mon, 26 Jan 2026 19:44:44 +0000 Subject: [PATCH] fix: use window.open for GitHub issue creation - Change from anchor tag to button with explicit window.open - Ensures click handler properly opens GitHub issue URL - Add disabled state to button when form is invalid --- docs/skillkit/components/SkillSubmitForm.tsx | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/docs/skillkit/components/SkillSubmitForm.tsx b/docs/skillkit/components/SkillSubmitForm.tsx index b8654613..4ad08310 100644 --- a/docs/skillkit/components/SkillSubmitForm.tsx +++ b/docs/skillkit/components/SkillSubmitForm.tsx @@ -267,8 +267,10 @@ ${form.skillContent.slice(0, 4000)}${form.skillContent.length > 4000 ? '\n...(tr } function handleSubmitClick(e: React.MouseEvent): void { - if (!isValid) { - e.preventDefault(); + e.preventDefault(); + if (isValid) { + const url = generateIssueUrl(); + window.open(url, '_blank', 'noopener,noreferrer'); } } @@ -527,11 +529,10 @@ ${form.skillContent.slice(0, 4000)}${form.skillContent.length > 4000 ? '\n...(tr )} - 4000 ? '\n...(tr > {GITHUB_ICON} {isImported ? 'Import to marketplace' : 'Publish skill'} - +

{isImported