From 380188cef107f8a01a8c86eecf623e561397eb21 Mon Sep 17 00:00:00 2001 From: Rohit Ghumare Date: Fri, 23 Jan 2026 22:27:37 +0000 Subject: [PATCH] fix: allow scoped npm names in isValidPluginName Update isValidPluginName to allow scoped npm package names like @scope/name while still preventing path traversal attacks. Uses the same regex pattern as loader.ts validatePlugin for consistency. Valid names: my-plugin, @scope/plugin-name Invalid names: ../evil, .hidden, name\\path, @../evil/name --- packages/cli/src/commands/plugin.ts | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/packages/cli/src/commands/plugin.ts b/packages/cli/src/commands/plugin.ts index 6c95f402..e6b4d969 100644 --- a/packages/cli/src/commands/plugin.ts +++ b/packages/cli/src/commands/plugin.ts @@ -123,15 +123,19 @@ export class PluginCommand extends Command { /** * Validate plugin name to prevent path traversal attacks + * Allows scoped npm names like @scope/name (mirrors loader.ts validation) */ private isValidPluginName(name: string): boolean { - // Reject empty, path separators, or path traversal sequences - return Boolean(name) && - !name.includes('/') && - !name.includes('\\') && - !name.includes('..') && - name !== '.' && - !name.startsWith('.'); + if (!name) return false; + + // Reject backslashes, path traversal sequences, and names starting with '.' + if (name.includes('\\') || name.includes('..') || name === '.' || name.startsWith('.')) { + return false; + } + + // Allow scoped npm names (@scope/name) or simple names (no slashes) + // Use the same regex pattern as loader.ts validatePlugin + return /^(?:@[a-z0-9-]+\/)?[a-z0-9-]+$/.test(name); } private async installPlugin(pluginManager: ReturnType): Promise {