From 2843bd3c5c3902d870199dc219ef263144d0aa3a Mon Sep 17 00:00:00 2001 From: Rohit Ghumare <48523873+rohitg00@users.noreply.github.com> Date: Mon, 20 Apr 2026 22:06:15 +0100 Subject: [PATCH] fix(install): address CodeRabbit review on agent picker wording MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Two nits from CodeRabbit on the first-user picker: 1. detectAgent() returns 'universal' as a fallback when no concrete adapter is detected. Passing that through to quickAgentSelect made the picker show "Just Universal (detected)" even when no real agent was found — misleading. Treat 'universal' as "not detected" and fall through to the plain select/all options instead. 2. The "All detected agents" label on the bottom option was wrong: agents at the call site is getAllAdapters() (all supported adapters), not only detected ones. Rename to "All supported agents" and change the hint to "writes to every adapter" so users aren't tricked into thinking this is a safe detected-only install. --- packages/cli/src/commands/install.ts | 3 ++- packages/cli/src/onboarding/prompts.ts | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/cli/src/commands/install.ts b/packages/cli/src/commands/install.ts index 3a531d8c..4dc70c49 100644 --- a/packages/cli/src/commands/install.ts +++ b/packages/cli/src/commands/install.ts @@ -357,7 +357,8 @@ export class InstallCommand extends Command { if (isInteractive) { const allAgentTypes = getAllAdapters().map((a) => a.type); const lastAgents = getLastAgents(); - const detectedAgent = await detectAgent().catch(() => undefined); + const rawDetected = await detectAgent().catch(() => undefined); + const detectedAgent = rawDetected && rawDetected !== 'universal' ? rawDetected : undefined; step(`Detected ${allAgentTypes.length} agents`); diff --git a/packages/cli/src/onboarding/prompts.ts b/packages/cli/src/onboarding/prompts.ts index 432465ae..88adb031 100644 --- a/packages/cli/src/onboarding/prompts.ts +++ b/packages/cli/src/onboarding/prompts.ts @@ -153,8 +153,8 @@ export async function quickAgentSelect(options: { selectOptions.push({ value: 'all', - label: 'All detected agents', - hint: `${agents.length} agent${agents.length !== 1 ? 's' : ''} — use only if you know`, + label: 'All supported agents', + hint: `${agents.length} agent${agents.length !== 1 ? 's' : ''} — writes to every adapter`, }); const result = await clack.select({