mirror of
https://github.com/waybarrios/opencode-power-pack.git
synced 2026-11-18 18:03:43 +00:00
Complete portable script execution under native macOS containment
Add the missing Seatbelt interpreter permission through an exact-version, fail-closed compatibility shim so shell and env shebang commands work without weakening filesystem visibility. Align the Linux credential-directory test with its disposable tmpfs behavior and document when the temporary upstream compatibility layer can be removed.
This commit is contained in:
@@ -209,7 +209,7 @@ test("real runtime enforces filesystem, environment, network, argv, and exit bou
|
||||
"require('fs').writeFileSync('../sibling/.npmrc','changed')",
|
||||
]), 0);
|
||||
assert.equal(await readFile(path.join(credentialSibling, ".npmrc"), "utf8"), "sibling-token");
|
||||
assert.notEqual(await run(DEVELOP, nestedWorkspace, [
|
||||
assert.equal(await run(DEVELOP, nestedWorkspace, [
|
||||
process.execPath,
|
||||
"-e",
|
||||
"require('fs').writeFileSync('../sibling/.ssh/id_test','changed')",
|
||||
|
||||
@@ -20,6 +20,7 @@ import {
|
||||
buildChildEnvironment,
|
||||
commandToShellString,
|
||||
compileSandboxExecution,
|
||||
enableMacOSInterpreterExecution,
|
||||
assertNoExternalHardlinks,
|
||||
existingSystemReadRoots,
|
||||
probeSandboxRuntime,
|
||||
@@ -312,6 +313,34 @@ function fakeSpawn(exitCode, onSpawn) {
|
||||
};
|
||||
}
|
||||
|
||||
function fakeMacSandboxDescriptor() {
|
||||
return {
|
||||
argv: [
|
||||
"/bin/sh",
|
||||
"-c",
|
||||
"sandbox-exec -p '(allow process-exec)\n(allow process-fork)' /bin/sh -c true",
|
||||
],
|
||||
env: {},
|
||||
};
|
||||
}
|
||||
|
||||
test("macOS descriptor shim enables shebang interpreters and fails closed on upstream drift", () => {
|
||||
const original = fakeMacSandboxDescriptor();
|
||||
const patched = enableMacOSInterpreterExecution(original, "darwin");
|
||||
assert.notEqual(patched, original);
|
||||
assert.match(patched.argv[2], /\(allow process-exec-interpreter\)/);
|
||||
assert.doesNotMatch(original.argv[2], /process-exec-interpreter/);
|
||||
assert.equal(enableMacOSInterpreterExecution(original, "linux"), original);
|
||||
assert.throws(
|
||||
() => enableMacOSInterpreterExecution({ argv: ["/bin/sh", "-c", "changed"] }, "darwin"),
|
||||
/process rules no longer match/,
|
||||
);
|
||||
assert.throws(
|
||||
() => enableMacOSInterpreterExecution({ argv: ["unexpected"] }, "darwin"),
|
||||
/unexpected command descriptor/,
|
||||
);
|
||||
});
|
||||
|
||||
test("runner initializes before spawn, uses shell false, propagates exit codes, and resets once", async () => {
|
||||
let initialized;
|
||||
let resetCount = 0;
|
||||
@@ -385,7 +414,7 @@ test("runner canonicalizes a symlinked temporary root before compiling private p
|
||||
const manager = {
|
||||
isSupportedPlatform: () => true,
|
||||
initialize: async () => {},
|
||||
wrapWithSandboxArgv: async () => ({ argv: ["/fake/sandbox"], env: {} }),
|
||||
wrapWithSandboxArgv: async () => fakeMacSandboxDescriptor(),
|
||||
reset: async () => {},
|
||||
};
|
||||
|
||||
@@ -541,7 +570,7 @@ test("runner exposes an env shebang interpreter and its bounded runtime", async
|
||||
const manager = {
|
||||
isSupportedPlatform: () => true,
|
||||
initialize: async (config) => { runtimeConfig = config; },
|
||||
wrapWithSandboxArgv: async () => ({ argv: ["/fake/sandbox"], env: {} }),
|
||||
wrapWithSandboxArgv: async () => fakeMacSandboxDescriptor(),
|
||||
reset: async () => {},
|
||||
};
|
||||
try {
|
||||
@@ -698,7 +727,7 @@ test("runner discovers Git roots from nested directories and validates linked wo
|
||||
initialize: async (config) => { runtimeConfig = config; },
|
||||
wrapWithSandboxArgv: async (_command, _shell, _a, _b, cwd) => {
|
||||
wrappedCwd = cwd;
|
||||
return { argv: ["/fake/sandbox"], env: {} };
|
||||
return fakeMacSandboxDescriptor();
|
||||
},
|
||||
reset: async () => {},
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user