Commit Graph
5 Commits
Author SHA1 Message Date
Sammy Farida f874b13d34 Security/fix command chaining bypass (#68)
* fix: Remove unused variable in fix-markdownlint.py

* fix: Remove unused code_block_lang variable

* chore: Update documentation, workflows, and examples

- Updated all wiki documentation files (markdownlint fixes)
- Updated GitHub workflows and issue templates
- Updated example configuration files
- Updated metadata.json and pyproject.toml
- Updated Dockerfile and compose files
- Updated validation scripts

Note: yamllint warnings are style-only (missing ---, line length) and don't affect functionality
2025-11-18 07:00:42 -05:00
Sammy Farida efa6e19099 feat: Improve SSH error handling with specific messages and per-host … (#67)
* feat: Improve SSH error handling with specific messages and per-host exception handling

- Enhanced SSH error messages with specific failure reasons:
  * Authentication failures, timeouts, connection refused
  * DNS resolution failures, host key verification errors
  * Key file errors (not found, permission denied, format invalid, passphrase required)
  * Network unreachable errors
- Added per-host exception handling in ssh_run_on_tag:
  * Individual host failures no longer stop entire operation
  * Each host's result included in results array with exit_code: -1 for failures
  * Proper task cleanup on failure
- Improved async task error handling with sanitized error messages
- Comprehensive test coverage:
  * 12 new unit tests for SSH error scenarios
  * 5 new integration tests for per-host handling
  * 7 new MCP compliance tests
- Added MCP Inspector test script for error handling validation
- Updated documentation:
  * Troubleshooting guide with detailed error message explanations
  * Tools reference with error handling documentation
  * CHANGELOG with all improvements

All error messages are sanitized for security (no IPs, hostnames, or file paths exposed).
Follows MCP specification requirements for error handling patterns.

* fix: Replace socket.timeout with TimeoutError per ruff UP041 rule

- Changed socket.timeout to TimeoutError in test_ssh_client_connection_timeout
- Fixes ruff linting error UP041
- Test still passes (TimeoutError is handled by existing exception handler)
2025-11-17 17:29:59 -05:00
Sammy Farida ab83aeabee docs: refresh security guidance (#64) 2025-11-15 10:08:14 -05:00
Sammy Farida 28392722a1 feat: add MCP resources, context logging, and denial hints (#63)
* feat: add MCP resources, context logging, and denial hints

* fix: resolve merge markers in mcp server

* chore: apply black formatting
2025-11-14 22:08:44 -05:00
Sammy Farida 1e36ddf28d feat: add multi-arch image description via outputs parameter (#55)
Add outputs parameter to docker/build-push-action to set annotations
on the multi-arch manifest index, enabling description to appear on
GitHub Packages.

Changes:
- Added outputs parameter with annotation-index.org.opencontainers.* keys
- Simplified description text to remove commas (prevents parsing conflicts)
- Description: 'A secure SSH fleet orchestrator for MCP STDIO transport...'
- Tested locally with Docker Buildx (all tests passed)
- Added comprehensive test script (scripts/test-annotations.sh)

Fixes missing description on GitHub Packages for multi-arch images.
See: https://docs.github.com/packages/working-with-a-github-packages-registry/working-with-the-container-registry#labelling-container-images
2025-11-13 11:47:42 -05:00