Sammy Farida
|
6a53e551c1
|
feat: Add input validation for user-controlled parameters (PR6) (#30)
**Security Enhancement:** Prevent injection attacks and resource exhaustion.
**Implementation:**
- Added validation helper functions: _validate_alias(), _validate_command(),
_validate_tag(), _validate_task_id()
- Alias validation: 100 char limit, alphanumeric/dash/underscore/dot only
- Command validation: 10,000 char limit, rejects null bytes and control chars
- Tag validation: 50 char limit, alphanumeric/dash/underscore/dot only
- Task ID validation: 200 char limit, format validation
- Applied validation to all MCP tools that accept user input
- Security event logging for injection attempts (null bytes, control chars)
**Tests Added:**
- 21 comprehensive tests for all validation functions
- Tests for valid inputs, empty inputs, length limits, invalid characters
- Tests for null byte and control character injection prevention
**Documentation:**
- Updated SECURITY.md with input validation section
- Updated Tools-Reference.md with input validation requirements
- Updated CHANGELOG.md with PR6 entry
**Security Impact:** Prevents injection attacks (null bytes, control characters)
and resource exhaustion (length limits) via malformed user inputs.
Fixes security vulnerability from CodeQL analysis.
|
2025-11-02 12:34:16 -05:00 |
|