From ef732615a43d06c2633e50841e699f4e0403bf0c Mon Sep 17 00:00:00 2001 From: Finessse Date: Wed, 17 Dec 2025 17:06:33 +0700 Subject: [PATCH] claude: do not auto-enable extended thinking --- .../chat-completions/claude_openai_request.go | 17 +++-------------- .../claude_openai-responses_request.go | 19 +++---------------- 2 files changed, 6 insertions(+), 30 deletions(-) diff --git a/internal/translator/claude/openai/chat-completions/claude_openai_request.go b/internal/translator/claude/openai/chat-completions/claude_openai_request.go index 443d5759..ebf55979 100644 --- a/internal/translator/claude/openai/chat-completions/claude_openai_request.go +++ b/internal/translator/claude/openai/chat-completions/claude_openai_request.go @@ -65,20 +65,9 @@ func ConvertOpenAIRequestToClaude(modelName string, inputRawJSON []byte, stream root := gjson.ParseBytes(rawJSON) - if v := root.Get("reasoning_effort"); v.Exists() { - out, _ = sjson.Set(out, "thinking.type", "enabled") - - switch v.String() { - case "none": - out, _ = sjson.Set(out, "thinking.type", "disabled") - case "low": - out, _ = sjson.Set(out, "thinking.budget_tokens", 1024) - case "medium": - out, _ = sjson.Set(out, "thinking.budget_tokens", 8192) - case "high": - out, _ = sjson.Set(out, "thinking.budget_tokens", 24576) - } - } + // Do not map OpenAI "reasoning_effort" to Claude extended thinking by default. + // Enabling Claude thinking requires assistant messages to start with a thinking block, + // which OpenAI-format requests do not provide and will be rejected upstream. // Helper for generating tool call IDs in the form: toolu_ // This ensures unique identifiers for tool calls in the Claude Code format diff --git a/internal/translator/claude/openai/responses/claude_openai-responses_request.go b/internal/translator/claude/openai/responses/claude_openai-responses_request.go index 5c700cec..af6d1ae6 100644 --- a/internal/translator/claude/openai/responses/claude_openai-responses_request.go +++ b/internal/translator/claude/openai/responses/claude_openai-responses_request.go @@ -52,22 +52,9 @@ func ConvertOpenAIResponsesRequestToClaude(modelName string, inputRawJSON []byte root := gjson.ParseBytes(rawJSON) - if v := root.Get("reasoning.effort"); v.Exists() { - out, _ = sjson.Set(out, "thinking.type", "enabled") - - switch v.String() { - case "none": - out, _ = sjson.Set(out, "thinking.type", "disabled") - case "minimal": - out, _ = sjson.Set(out, "thinking.budget_tokens", 1024) - case "low": - out, _ = sjson.Set(out, "thinking.budget_tokens", 4096) - case "medium": - out, _ = sjson.Set(out, "thinking.budget_tokens", 8192) - case "high": - out, _ = sjson.Set(out, "thinking.budget_tokens", 24576) - } - } + // Do not map OpenAI "reasoning.effort" to Claude extended thinking by default. + // Enabling Claude thinking requires assistant messages to start with a thinking block, + // which OpenAI-format requests do not provide and will be rejected upstream. // Helper for generating tool call IDs when missing genToolCallID := func() string {