From bf4f0bc5792f489b3c44dff93ffa6dc45065d407 Mon Sep 17 00:00:00 2001 From: RCD <90105158+Finesssee@users.noreply.github.com> Date: Sat, 4 Apr 2026 16:31:33 +0700 Subject: [PATCH] fix(security): remove unverified management asset fallback --- internal/managementasset/updater.go | 30 ++--------------------------- 1 file changed, 2 insertions(+), 28 deletions(-) diff --git a/internal/managementasset/updater.go b/internal/managementasset/updater.go index ae2bc819..cbbddca9 100644 --- a/internal/managementasset/updater.go +++ b/internal/managementasset/updater.go @@ -26,7 +26,6 @@ import ( const ( defaultManagementReleaseURL = "https://api.github.com/repos/router-for-me/Cli-Proxy-API-Management-Center/releases/latest" - defaultManagementFallbackURL = "https://cpamc.router-for.me/" managementAssetName = "management.html" httpUserAgent = "CLIProxyAPI-management-updater" managementSyncMinInterval = 30 * time.Second @@ -235,10 +234,7 @@ func EnsureLatestManagementHTML(ctx context.Context, staticDir string, proxyURL asset, remoteHash, err := fetchLatestAsset(ctx, client, releaseURL) if err != nil { if localFileMissing { - log.WithError(err).Warn("failed to fetch latest management release information, trying fallback page") - if ensureFallbackManagementHTML(ctx, client, localPath) { - return nil, nil - } + log.WithError(err).Warn("failed to fetch latest management release information and local management asset is missing") return nil, nil } log.WithError(err).Warn("failed to fetch latest management release information") @@ -253,10 +249,7 @@ func EnsureLatestManagementHTML(ctx context.Context, staticDir string, proxyURL data, downloadedHash, err := downloadAsset(ctx, client, asset.BrowserDownloadURL) if err != nil { if localFileMissing { - log.WithError(err).Warn("failed to download management asset, trying fallback page") - if ensureFallbackManagementHTML(ctx, client, localPath) { - return nil, nil - } + log.WithError(err).Warn("failed to download management asset and local management asset is missing") return nil, nil } log.WithError(err).Warn("failed to download management asset") @@ -281,25 +274,6 @@ func EnsureLatestManagementHTML(ctx context.Context, staticDir string, proxyURL return err == nil } -func ensureFallbackManagementHTML(ctx context.Context, client *http.Client, localPath string) bool { - data, downloadedHash, err := downloadAsset(ctx, client, defaultManagementFallbackURL) - if err != nil { - log.WithError(err).Warn("failed to download fallback management control panel page") - return false - } - - log.Warnf("management asset downloaded from fallback URL without digest verification (hash=%s) — "+ - "enable verified GitHub updates by keeping disable-auto-update-panel set to false", downloadedHash) - - if err = atomicWriteFile(localPath, data); err != nil { - log.WithError(err).Warn("failed to persist fallback management control panel page") - return false - } - - log.Infof("management asset updated from fallback page successfully (hash=%s)", downloadedHash) - return true -} - func resolveReleaseURL(repo string) string { repo = strings.TrimSpace(repo) if repo == "" {